fix s3prl upstream attribute bug#5003
Merged
sw005320 merged 3 commits intoespnet:masterfrom Mar 14, 2023
Merged
Conversation
fix upstream attribute bug that interferes with layerdrop on Wav2vec2 and Hubert. `upstream` has an attribute ` upstream` that acctually contains the `model` attribute
Update s3prl.py
Codecov Report
@@ Coverage Diff @@
## master #5003 +/- ##
==========================================
+ Coverage 76.98% 77.00% +0.02%
==========================================
Files 606 606
Lines 53748 53748
==========================================
+ Hits 41377 41388 +11
+ Misses 12371 12360 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
simpleoier
approved these changes
Mar 13, 2023
Collaborator
simpleoier
left a comment
There was a problem hiding this comment.
This fix looks good to me. The model name is at one level deeper.
Thanks!
Contributor
|
Thanks for your quick action! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix s3prl upstream attribute bug: variable
upstreamof the classS3PRLUpstreamdoes not have anmodelattribute and thus theifstatement that is responsible for settingencoder.layerdrop = 0never gets evaluated toTrue. Quick Fix includes using theupstreamattribute ofupstreamto correctly get attribute values.