Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CHiME-7 DASR: first diarization system based on Pyannote. #5054

Merged
mergify[bot] merged 70 commits intoespnet:masterfrom
popcornell:chime7task1_diar
Apr 6, 2023
Merged

CHiME-7 DASR: first diarization system based on Pyannote. #5054
mergify[bot] merged 70 commits intoespnet:masterfrom
popcornell:chime7task1_diar

Conversation

@popcornell
Copy link
Contributor

I added a very simple diarization system based on pyannote, it mainly serves the purpose of showcasing how to integrate the diarization with the rest.
TS-VAD incoming in the meantime.

Made another folder into the chime7_dasr recipe called diar_asr1 as it does diarization + asr (actually also enhancement via GSS).
Lots of symbolic links to the asr1 folder however.

@popcornell popcornell changed the title First diarization system based on Pyannote. CHiME-7 DASR: first diarization system based on Pyannote. Mar 23, 2023
@mergify mergify bot added the ESPnet2 label Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #5054 (d1d5c70) into master (78db412) will decrease coverage by 6.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5054      +/-   ##
==========================================
- Coverage   75.88%   69.72%   -6.16%     
==========================================
  Files         615      615              
  Lines       54767    54767              
==========================================
- Hits        41559    38186    -3373     
- Misses      13208    16581    +3373     
Flag Coverage Δ
test_integration_espnet1 ?
test_integration_espnet2 47.82% <ø> (-0.68%) ⬇️
test_python 65.84% <ø> (-0.03%) ⬇️
test_utils 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to delete the log file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept it on purpose so people can see the full results and compare with their

Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.
They look good to me, overall.

Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sw005320 sw005320 added the auto-merge Enable auto-merge label Apr 6, 2023
@mergify mergify bot merged commit 1470138 into espnet:master Apr 6, 2023
pretrained_affix+="--download_model ${use_pretrained}"
fi

if [ $diar_score ]; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be changed to if [ $diar_score -eq 1 ]; then, otherwise this condition will always evaluate to True.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASR Automatic speech recogntion auto-merge Enable auto-merge ESPnet2 README Recipe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants