Bug Fix: pretrained s3prl-frontend based models loaded with parameters key mismatch error#5074
Merged
mergify[bot] merged 2 commits intoespnet:masterfrom Apr 1, 2023
Merged
Conversation
Contributor
|
Can you fix some CI errors? |
4b511f6 to
48904c7
Compare
Contributor
|
Thanks, @simpleoier! |
…ers key mismatch error
48904c7 to
daf1233
Compare
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #5074 +/- ##
==========================================
- Coverage 75.86% 75.85% -0.02%
==========================================
Files 615 615
Lines 54689 54698 +9
==========================================
+ Hits 41491 41492 +1
- Misses 13198 13206 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
boeddeker
reviewed
Apr 3, 2023
| device = f"cuda:{torch.cuda.current_device()}" | ||
| model.load_state_dict(torch.load(model_file, map_location=device)) | ||
| try: | ||
| model.load_state_dict(torch.load(model_file, map_location=device)) |
Contributor
There was a problem hiding this comment.
Could you change this to
state_dict = torch.load(model_file, map_location=device)
try:
model.load_state_dict(state_dict)and remove the later call of torch.load?
Contributor
|
Sorry for the late reply. Yes, the code works to load an old model. Thanks. Could that be fixed? (See my comment in the code) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #4910 .
Thanks @boeddeker for the solution!