Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Limit the Numpy version (<1.24) to fix CI error temporarily.#5162

Merged
mergify[bot] merged 1 commit intoespnet:masterfrom
simpleoier:remove_test_hubert_loss
May 11, 2023
Merged

Limit the Numpy version (<1.24) to fix CI error temporarily.#5162
mergify[bot] merged 1 commit intoespnet:masterfrom
simpleoier:remove_test_hubert_loss

Conversation

@simpleoier
Copy link
Collaborator

@simpleoier simpleoier commented May 10, 2023

This PR is intended to fix the CI errors. Due to the deprecation of numpy aliases, e.g. np.float, np.int, errors were raised in several packages (e.g. fairseq, librosa, etc).

Timeline:

  1. Try to remove fairseq dependency, espeically in test.
  2. Several other packages raise the same error. So the current solution is to constrain the numpy version (<1.24).

@sw005320 sw005320 added Bugfix CI Travis, Circle CI, etc labels May 10, 2023
@sw005320 sw005320 added this to the v.202307 milestone May 10, 2023
@sw005320 sw005320 added the auto-merge Enable auto-merge label May 10, 2023
@sw005320
Copy link
Contributor

Thanks!
It would be great if you also remove corresponding parts later since they are not used anymore.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #5162 (16a813b) into master (33aa097) will increase coverage by 8.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5162      +/-   ##
==========================================
+ Coverage   66.13%   74.99%   +8.86%     
==========================================
  Files         618      618              
  Lines       55588    55588              
==========================================
+ Hits        36763    41689    +4926     
+ Misses      18825    13899    -4926     
Flag Coverage Δ
test_integration_espnet1 66.28% <ø> (?)
test_integration_espnet2 47.61% <ø> (?)
test_python 65.45% <ø> (ø)
test_utils 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 107 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@simpleoier simpleoier force-pushed the remove_test_hubert_loss branch from c4c2c46 to 16a813b Compare May 10, 2023 16:36
@mergify mergify bot added the Installation label May 10, 2023
@simpleoier simpleoier changed the title remove the hubert loss test to fix CI error temporarily. Limit the Numpy version (<1.24) to fix CI error temporarily. May 11, 2023
@mergify mergify bot merged commit 4430286 into espnet:master May 11, 2023
@rinarakaki rinarakaki mentioned this pull request Jan 18, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Enable auto-merge Bugfix CI Travis, Circle CI, etc Installation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants