fix the s3prl frontend gradient backprop bug, ensuring feature_grad_mult=1.0#5297
Merged
mergify[bot] merged 2 commits intoespnet:masterfrom Jul 21, 2023
Merged
fix the s3prl frontend gradient backprop bug, ensuring feature_grad_mult=1.0#5297mergify[bot] merged 2 commits intoespnet:masterfrom
mergify[bot] merged 2 commits intoespnet:masterfrom
Conversation
Contributor
|
I can observe clear differences in |
Contributor
|
I get the accuracy of the first epoch that is comparable with that with the older version of S3PRL while causing artifacts in enhanced speech. |
Collaborator
Author
|
@YoshikiMas Thank you! |
Contributor
|
@YoshikiMas and @simpleoier, can I merge this PR? |
Codecov Report
@@ Coverage Diff @@
## master #5297 +/- ##
=======================================
Coverage 76.10% 76.10%
=======================================
Files 658 658
Lines 59156 59156
=======================================
Hits 45022 45022
Misses 14134 14134
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
feature_grad_multfor s3prl frontend.feature_grad_multis set to0.0by s3prl, the if clause will not be executed.feature_grad_mult=0.0, due to float(0.0) precision issue.@Emrys365 @YoshikiMas