Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Cython version to pass the installation of libraries with Cython#5310

Merged
sw005320 merged 7 commits intoespnet:masterfrom
kan-bayashi:fix/fix-installation-with-cython
Jul 20, 2023
Merged

Fix Cython version to pass the installation of libraries with Cython#5310
sw005320 merged 7 commits intoespnet:masterfrom
kan-bayashi:fix/fix-installation-with-cython

Conversation

@kan-bayashi
Copy link
Member

@kan-bayashi kan-bayashi commented Jul 20, 2023

@kan-bayashi kan-bayashi added CI Travis, Circle CI, etc Installation labels Jul 20, 2023
@kan-bayashi kan-bayashi changed the title fix Cython version Fix Cython version to pass the installation of libraries with Cython Jul 20, 2023
@sw005320 sw005320 added this to the v.202307 milestone Jul 20, 2023
@kan-bayashi kan-bayashi force-pushed the fix/fix-installation-with-cython branch from 6bc71c8 to 3723f59 Compare July 20, 2023 13:22
@kan-bayashi kan-bayashi force-pushed the fix/fix-installation-with-cython branch from 5e568c9 to 95cdeff Compare July 20, 2023 13:30
[ -e tdmelodic_pyopenjtalk.done ] && rm tdmelodic_pyopenjtalk.done
python3 -m pip install pyopenjtalk==0.3.0
# NOTE(kan-bayashi): Should update after new version release
python3 -m pip install --no-build-isolation pyopenjtalk==0.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the update :) I've released a new version 0.3.1: https://github.com/r9y9/pyopenjtalk/releases/tag/v0.3.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you GOD

@kan-bayashi kan-bayashi force-pushed the fix/fix-installation-with-cython branch from bf88a38 to 17dd972 Compare July 20, 2023 14:03
@kan-bayashi kan-bayashi force-pushed the fix/fix-installation-with-cython branch from 17dd972 to 77f9d4f Compare July 20, 2023 14:11
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #5310 (7f6b289) into master (babd81f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5310   +/-   ##
=======================================
  Coverage   67.12%   67.13%           
=======================================
  Files         658      658           
  Lines       59145    59156   +11     
=======================================
+ Hits        39701    39712   +11     
  Misses      19444    19444           
Flag Coverage Δ
test_python 66.49% <ø> (+<0.01%) ⬆️
test_utils 23.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320
Copy link
Contributor

We still have an espnet1 integration test issue, but anyway, Cython issues were fixed.
I merge this PR!

@sw005320 sw005320 merged commit 8a66170 into espnet:master Jul 20, 2023
@kan-bayashi kan-bayashi deleted the fix/fix-installation-with-cython branch July 20, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Travis, Circle CI, etc Installation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants