Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PR Labels for CI control #5320

Merged
kan-bayashi merged 36 commits intoespnet:masterfrom
Fhrozen:pr-cilabels
Jul 22, 2023
Merged

PR Labels for CI control #5320
kan-bayashi merged 36 commits intoespnet:masterfrom
Fhrozen:pr-cilabels

Conversation

@Fhrozen
Copy link
Member

@Fhrozen Fhrozen commented Jul 21, 2023

What

Implement the use of PR labels in the CI tests.

Why

Reduce the time of the CI by constraining the test to the respective modifications.

@mergify mergify bot added the CI Travis, Circle CI, etc label Jul 21, 2023
@Fhrozen
Copy link
Member Author

Fhrozen commented Jul 21, 2023

@sw005320 @kan-bayashi The labels were implemented in two different configurations:
Using a previous step to skip the evaluations, and probably add values to the matrix strategy, using the labels (such as in .github/workflows/ci.yaml jobs: get_labels. Or, catching the labels inside the scripts, such as in ci/install.sh.
A test was implemented for skipping tests if only docker label is present in the PR, and espnet1 and espnet2 are not present.

Let me know your opinion to modify it.

@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited
Loading

Codecov Report

Merging #5320 (dd0cbc2) into master (6ca49f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5320   +/-   ##
=======================================
  Coverage   76.11%   76.11%           
=======================================
  Files         672      672           
  Lines       59859    59859           
=======================================
  Hits        45561    45561           
  Misses      14298    14298
Flag Coverage Δ
test_integration_espnet1 65.93% <ø> (ø)
test_integration_espnet2 47.92% <ø> (ø)
test_python 66.40% <ø> (ø)
test_utils 23.00% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2023

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Jul 21, 2023
@mergify mergify bot removed the conflicts label Jul 21, 2023
@Fhrozen Fhrozen changed the title [WIP] PR Labels for CI control PR Labels for CI control Jul 22, 2023
kan-bayashi
kan-bayashi reviewed Jul 22, 2023
View reviewed changes
kan-bayashi
kan-bayashi requested changes Jul 22, 2023
View reviewed changes
@kan-bayashi kan-bayashi merged commit 8ed5d5c into espnet:master Jul 22, 2023
@Fhrozen Fhrozen deleted the pr-cilabels branch July 22, 2023 22:24
@Fhrozen Fhrozen mentioned this pull request Jul 22, 2023
Merged
@kan-bayashi kan-bayashi mentioned this pull request Jul 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kan-bayashi kan-bayashi kan-bayashi approved these changes

Assignees

No one assigned

Labels

CI Travis, Circle CI, etc Need review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fhrozen @kan-bayashi