Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Minimize espnet2 integration test#5324

Merged
mergify[bot] merged 13 commits intoespnet:masterfrom
kan-bayashi:feat/minimize-integration-test
Jul 22, 2023
Merged

Minimize espnet2 integration test#5324
mergify[bot] merged 13 commits intoespnet:masterfrom
kan-bayashi:feat/minimize-integration-test

Conversation

@kan-bayashi
Copy link
Member

@kan-bayashi kan-bayashi commented Jul 21, 2023 •
edited
Loading

What?

  • Minimize the parameters used in egs2/mini_an4 to reduce the integration test time

Why?

  • ESPnet2 integration test consumes too much time

ToDo

  • asr1
  • tts1
  • enh1
  • tse1
  • ssl1
  • enh_asr1
  • st1
  • asr2

@mergify mergify bot added ESPnet2 CI Travis, Circle CI, etc labels Jul 21, 2023
@kan-bayashi kan-bayashi force-pushed the feat/minimize-integration-test branch from d98294c to b0e9544 Compare July 21, 2023 12:58
@sw005320 sw005320 added this to the v.202307 milestone Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited
Loading

Codecov Report

Merging #5324 (5c3bdde) into master (249bf6e) will decrease coverage by 3.58%.
The diff coverage is n/a.

❗ Current head 5c3bdde differs from pull request most recent head 14819cd. Consider uploading reports for the commit 14819cd to get more accurate results

@@            Coverage Diff             @@
##           master    #5324      +/-   ##
==========================================
- Coverage   76.13%   72.55%   -3.58%     
==========================================
  Files         672      669       -3     
  Lines       59859    59566     -293     
==========================================
- Hits        45571    43221    -2350     
- Misses      14288    16345    +2057
Flag Coverage Δ
test_integration_espnet1 65.93% <ø> (ø)
test_integration_espnet2 ?
test_python 66.56% <ø> (+0.16%) ⬆️
test_utils 23.06% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 69 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320
Copy link
Contributor

sw005320 commented Jul 21, 2023

@simpleoier, can you review the SSL and se_asr part?

@simpleoier
Copy link
Collaborator

simpleoier commented Jul 21, 2023

SSL and enh_asr parts look good to me.
Thanks!

@kan-bayashi kan-bayashi mentioned this pull request Jul 21, 2023
Merged
@kan-bayashi
Copy link
Member Author

kan-bayashi commented Jul 21, 2023

CI is too busy, I will test in my fork.
kan-bayashi#7

@kan-bayashi kan-bayashi marked this pull request as draft July 21, 2023 23:55
@kan-bayashi kan-bayashi force-pushed the feat/minimize-integration-test branch 8 times, most recently from 2350831 to 5bcfe96 Compare July 22, 2023 03:51
@kan-bayashi kan-bayashi marked this pull request as ready for review July 22, 2023 05:58
@kan-bayashi kan-bayashi added the auto-merge Enable auto-merge label Jul 22, 2023
@kan-bayashi
Copy link
Member Author

kan-bayashi commented Jul 22, 2023

I confirmed it works.
https://github.com/kan-bayashi/espnet/actions/runs/5628662480/job/15252776691
But the required time of integration test is still around 1 hour.

@kan-bayashi
Copy link
Member Author

kan-bayashi commented Jul 22, 2023

I will further accelerate by splitting CI in #5336

@kan-bayashi kan-bayashi mentioned this pull request Jul 22, 2023
Closed
@mergify
Copy link
Contributor

mergify bot commented Jul 22, 2023

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Jul 22, 2023
@kan-bayashi kan-bayashi force-pushed the feat/minimize-integration-test branch from 5c3bdde to 3cc0497 Compare July 22, 2023 08:12
@mergify mergify bot removed the conflicts label Jul 22, 2023
@kan-bayashi kan-bayashi force-pushed the feat/minimize-integration-test branch from 3cc0497 to 14819cd Compare July 22, 2023 08:15
@kan-bayashi kan-bayashi mentioned this pull request Jul 22, 2023
Merged
@mergify mergify bot merged commit 6ca49f4 into espnet:master Jul 22, 2023
@kan-bayashi kan-bayashi deleted the feat/minimize-integration-test branch July 23, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge Enable auto-merge CI Travis, Circle CI, etc ESPnet2

Projects

None yet

Milestone

v.202307

Development

Successfully merging this pull request may close these issues.

3 participants

@kan-bayashi @sw005320 @simpleoier