Add musdb18 recipe for music source separation#5338
Merged
sw005320 merged 6 commits intoespnet:masterfrom Jul 23, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5338 +/- ##
==========================================
- Coverage 76.21% 76.11% -0.10%
==========================================
Files 669 672 +3
Lines 59565 59859 +294
==========================================
+ Hits 45395 45563 +168
- Misses 14170 14296 +126
Flags with carried forward coverage won't be shown. Click here to find out more. see 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
YoshikiMas
reviewed
Jul 23, 2023
egs2/musdb18/enh1/local/data.sh
Outdated
|
|
||
| if [ $nchannels -eq 1 ]; then | ||
| log "Use single channel audios" | ||
| elif [ $nchannels -eq 1 ]; then |
Contributor
There was a problem hiding this comment.
It should be -eq 2, right?
Collaborator
Author
There was a problem hiding this comment.
Oh thanks for noticing that! I have fixed it.
ftshijt
reviewed
Jul 23, 2023
Collaborator
ftshijt
left a comment
There was a problem hiding this comment.
LGTM! A minor suggestion as follows:
Comment on lines
+151
to
+154
| sed -e "s#/mixture.wav#/drums.wav#g" "${cdir}/data/${dset}/wav.scp" > "${cdir}/data/${dset}/spk1.scp" | ||
| sed -e "s#/mixture.wav#/bass.wav#g" "${cdir}/data/${dset}/wav.scp" > "${cdir}/data/${dset}/spk2.scp" | ||
| sed -e "s#/mixture.wav#/vocals.wav#g" "${cdir}/data/${dset}/wav.scp" > "${cdir}/data/${dset}/spk3.scp" | ||
| sed -e "s#/mixture.wav#/other.wav#g" "${cdir}/data/${dset}/wav.scp" > "${cdir}/data/${dset}/spk4.scp" |
Collaborator
There was a problem hiding this comment.
Is it possible to add a readme in this recipe, where we can discuss the mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new recipe for music source separation.
I followed the musdb package to obtain the training-validation splits.