Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ESPnet-SPK: sampler#5365

Merged
mergify[bot] merged 60 commits intoespnet:masterfrom
Jungjee:spk_sampler
Aug 7, 2023
Merged

ESPnet-SPK: sampler#5365
mergify[bot] merged 60 commits intoespnet:masterfrom
Jungjee:spk_sampler

Conversation

@Jungjee
Copy link
Contributor

@Jungjee Jungjee commented Jul 24, 2023

What?

A specialized data sampling strategy for speaker recognition is added.
It can be used (recommended) for classification-trained tasks such as language identification and anti-spoofing, etc.

Why?

Has a big impact on performance, but not implemented yet.

@mergify mergify bot added the ESPnet2 label Jul 24, 2023
@Jungjee Jungjee marked this pull request as ready for review July 25, 2023 03:42
@mergify mergify bot added the README label Aug 3, 2023
@mergify mergify bot added the CI Travis, Circle CI, etc label Aug 3, 2023
Jungjee added a commit to Jungjee/espnet that referenced this pull request Aug 3, 2023
Jungjee added a commit to Jungjee/espnet that referenced this pull request Aug 3, 2023
@Jungjee
Copy link
Contributor Author

Jungjee commented Aug 3, 2023

Hi @sw005320, there are still some coverage alerts regarding the new sampler, however, these seem to be coming mostly from one epoch, one batch nature. Do you think it can be merged?

Once merged, I will move on to #5385

fix minor typos
Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I have only one comment.

type: mini-batch type. "unsorted", "sorted", "folded", "numel", or, "length"
batch_size: The mini-batch size. Used for "unsorted", "sorted", "folded" mode
type: mini-batch type. "unsorted", "sorted", "folded", "numel",
"length", or "catbel"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I just did. Let me know if you want supplement.

@mergify mergify bot added the Documentation label Aug 7, 2023
@sw005320
Copy link
Contributor

sw005320 commented Aug 7, 2023

Thanks a lot!
After the CI check, I’ll merge this PR.

@sw005320 sw005320 added the auto-merge Enable auto-merge label Aug 7, 2023
@sw005320 sw005320 added this to the v.202312 milestone Aug 7, 2023
@mergify mergify bot merged commit ac8b312 into espnet:master Aug 7, 2023
@Jungjee Jungjee deleted the spk_sampler branch August 8, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Enable auto-merge CI Travis, Circle CI, etc Documentation ESPnet2 README

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants