Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ASR2 CHiME4 & Gigaspeech Recipes#5434

Merged
ftshijt merged 43 commits intoespnet:masterfrom
yichen14:master
Oct 2, 2023
Merged

ASR2 CHiME4 & Gigaspeech Recipes#5434
ftshijt merged 43 commits intoespnet:masterfrom
yichen14:master

Conversation

@yichen14
Copy link
Contributor

@yichen14 yichen14 commented Sep 16, 2023

What?

Add ASR discrete token recipes for CHiME4 and Gigaspeech.

Why?

Extend ASR2 for both dataset, and update exp result.

See also

None

@sw005320 sw005320 requested a review from simpleoier September 16, 2023 20:37
@sw005320 sw005320 added Recipe ASR Automatic speech recogntion labels Sep 16, 2023
@sw005320 sw005320 added this to the v.202312 milestone Sep 16, 2023
simpleoier
simpleoier reviewed Sep 16, 2023
View reviewed changes
Copy link
Collaborator

@simpleoier simpleoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts! The results are really cool!
I left some comments. Please reflect them.

yichen14 and others added 9 commits September 17, 2023 00:58
@yichen14
asr2.sh typo
965b413
@yichen14
Update data.sh
0aba350
@yichen14
Delete egs2/gigaspeech/asr2/conf/tuning/train_asr_conformer6_n_fft512…
2819ef3 
…_hop_length256.yaml
@yichen14
Update and rename train_discrete_asr_e_branchformer1_e12.yaml to trai…
9847c85 
…n_discrete_asr_e_branchformer1_e12_lr.yaml
@yichen14
Delete egs2/gigaspeech/asr2/conf/tuning/train_asr_e_branchformer_e17_…
e2f5264 
…size512_mlp3072_linear1024_layerdrop.yaml
@yichen14
Delete egs2/gigaspeech/asr2/conf/tuning/train_discrete_asr_e_branchfo…
3b7eec9 
…rmer1_e17_size512_mlp3072_linear1024_layerdrop.yaml
@yichen14
Delete egs2/gigaspeech/asr2/conf/tuning/train_discrete_asr_e_branchfo…
5239541 
…rmer1_e12_subsamp.yaml
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
746aae3 
for more information, see https://pre-commit.ci
change to sym link
904c147
@yichen14
Copy link
Contributor Author

yichen14 commented Sep 17, 2023

Thanks for your efforts! The results are really cool! I left some comments. Please reflect them.

Hi Xuankai, thank you for the review! I've resolved those comments.

simpleoier
simpleoier reviewed Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@simpleoier simpleoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you address the following comments?

simpleoier
simpleoier reviewed Sep 18, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #5434 (ff29ffa) into master (8457fe2) will decrease coverage by 0.02%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master    #5434      +/-   ##
==========================================
- Coverage   77.17%   77.16%   -0.02%     
==========================================
  Files         684      684              
  Lines       62686    62706      +20     
==========================================
+ Hits        48379    48384       +5     
- Misses      14307    14322      +15
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 65.68% <22.22%> (-0.05%) ⬇️
test_integration_espnet2 49.06% <25.00%> (-0.02%) ⬇️
test_python_espnet1 19.94% <20.00%> (+<0.01%) ⬆️
test_python_espnet2 52.30% <30.00%> (-0.01%) ⬇️
test_utils 23.09% <22.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
espnet2/asr/encoder/e_branchformer_encoder.py 93.56% <50.00%> (-0.44%) ⬇️
...et/nets/pytorch_backend/transformer/subsampling.py 77.02% <27.77%> (-6.82%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sw005320
sw005320 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
Thanks

@sw005320
Copy link
Contributor

sw005320 commented Sep 20, 2023

Please fix https://github.com/espnet/espnet/actions/runs/6251855635/job/16973860054?pr=5434#step:8:644

simpleoier
simpleoier approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@simpleoier simpleoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
It's ready after fixing the CI errors.

@sw005320
Copy link
Contributor

sw005320 commented Sep 27, 2023

@yichen14, please fix https://github.com/espnet/espnet/actions/runs/6158168923/job/16807750493?pr=5427#step:7:100515
We're almost there.

@sw005320
Copy link
Contributor

sw005320 commented Sep 28, 2023

Hi @yichen14, this is a reminder.

@yichen14
Copy link
Contributor Author

yichen14 commented Sep 28, 2023

Sorry I missed previous comment, I'll fix it today

@ftshijt
Copy link
Collaborator

ftshijt commented Oct 2, 2023

Thanks for your contribution!

@ftshijt ftshijt merged commit 458b428 into espnet:master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simpleoier simpleoier simpleoier approved these changes

@sw005320 sw005320 sw005320 approved these changes

Assignees

No one assigned

Labels

ASR Automatic speech recogntion ESPnet1 ESPnet2 README Recipe

Projects

None yet

Milestone

v.202310

Development

Successfully merging this pull request may close these issues.

4 participants

@yichen14 @sw005320 @ftshijt @simpleoier