Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update setup.py#5490

Merged
sw005320 merged 1 commit intomasterfrom
sw005320-patch-1
Oct 20, 2023
Merged

Update setup.py#5490
sw005320 merged 1 commit intomasterfrom
sw005320-patch-1

Conversation

@sw005320
Copy link
Contributor

@sw005320 sw005320 commented Oct 19, 2023

What?

Removing the protobuf version restriction.

Why?

The protobuf version restriction affects other packages.

See also

See #5488

@mergify mergify bot added the Installation label Oct 19, 2023
@sw005320 sw005320 added this to the v.202312 milestone Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #5490 (af48d9e) into master (93dafc3) will increase coverage by 4.54%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5490      +/-   ##
==========================================
+ Coverage   70.82%   75.37%   +4.54%     
==========================================
  Files         709      709              
  Lines       65290    65290              
==========================================
+ Hits        46244    49211    +2967     
+ Misses      19046    16079    -2967     
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 65.67% <ø> (ø)
test_integration_espnet2 48.71% <ø> (?)
test_python_espnet1 19.16% <ø> (ø)
test_python_espnet2 51.40% <ø> (+0.04%) ⬆️
test_utils 23.10% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 83 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320 sw005320 merged commit 7739c50 into master Oct 20, 2023
@sw005320 sw005320 deleted the sw005320-patch-1 branch October 20, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant