Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix bugs of Whisper SOT.#5494

Merged
sw005320 merged 1 commit intoespnet:masterfrom
pengchengguo:whisper
Oct 21, 2023
Merged

Fix bugs of Whisper SOT.#5494
sw005320 merged 1 commit intoespnet:masterfrom
pengchengguo:whisper

Conversation

@pengchengguo
Copy link
Collaborator

Fix bugs in the Whisper SOT implementation.

  1. In whisper_export_vocabulary.py, the type of --sot_asr should be str2bool;
  2. In class CommonPreprocessor_multi, add whisper_language and whisper_task to support more datasets.

@mergify mergify bot added the ESPnet2 label Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #5494 (2b71a1b) into master (0c298af) will increase coverage by 5.11%.
Report is 48 commits behind head on master.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #5494      +/-   ##
==========================================
+ Coverage   70.26%   75.37%   +5.11%     
==========================================
  Files         707      709       +2     
  Lines       64942    65291     +349     
==========================================
+ Hits        45630    49212    +3582     
+ Misses      19312    16079    -3233     
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 65.67% <ø> (ø)
test_integration_espnet2 48.71% <0.00%> (?)
test_python_espnet1 19.16% <0.00%> (-0.11%) ⬇️
test_python_espnet2 51.40% <25.00%> (+0.58%) ⬆️
test_utils 23.10% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
espnet2/bin/whisper_export_vocabulary.py 93.33% <100.00%> (+76.38%) ⬆️
espnet2/train/preprocessor.py 75.91% <0.00%> (+54.99%) ⬆️

... and 137 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320 sw005320 added Bugfix ASR Automatic speech recogntion labels Oct 21, 2023
@sw005320 sw005320 added this to the v.202312 milestone Oct 21, 2023
@sw005320 sw005320 merged commit 01037ca into espnet:master Oct 21, 2023
@sw005320
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASR Automatic speech recogntion Bugfix ESPnet2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants