Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ESPnet-SPK: add Voxblink recipe#5583

Merged
mergify[bot] merged 25 commits intoespnet:masterfrom
Jungjee:voxblink_spk
Jan 4, 2024
Merged

ESPnet-SPK: add Voxblink recipe#5583
mergify[bot] merged 25 commits intoespnet:masterfrom
Jungjee:voxblink_spk

Conversation

@Jungjee
Copy link
Contributor

@Jungjee Jungjee commented Dec 8, 2023

What?

Add a spk1 recipe on VoxBlink dataset

Why?

Provide diverse recipes for ESPnet-SPK

See also

https://voxblink.github.io/

@mergify mergify bot added the ESPnet2 label Dec 8, 2023
@Jungjee Jungjee marked this pull request as ready for review December 8, 2023 18:05
@Jungjee
Copy link
Contributor Author

Jungjee commented Dec 8, 2023

@sw005320, I think recipe's ready, but test_python is dying with different errors.
Should I wait a bit?

@codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f732a75) 24.26% compared to head (5190d5e) 76.54%.
Report is 10 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #5583       +/-   ##
===========================================
+ Coverage   24.26%   76.54%   +52.27%     
===========================================
  Files         719      720        +1     
  Lines       66599    66639       +40     
===========================================
+ Hits        16161    51008    +34847     
+ Misses      50438    15631    -34807
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 62.92% <ø> (ø)
test_integration_espnet2 50.10% <ø> (?)
test_python_espnet1 19.08% <ø> (ø)
test_python_espnet2 52.39% <ø> (?)
test_utils 22.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sw005320
Copy link
Contributor

sw005320 commented Dec 14, 2023

Thanks!
After you add the results and uploaded model links, I'll merge this PR.

@sw005320 sw005320 added Recipe SID Speaker identification/embedding labels Dec 14, 2023
@sw005320 sw005320 added this to the v.202312 milestone Dec 14, 2023
@mergify mergify bot added the README label Dec 26, 2023
@Jungjee
Copy link
Contributor Author

Jungjee commented Jan 4, 2024 •
edited
Loading

Thanks! After you add the results and uploaded model links, I'll merge this PR.

Hi @sw005320, I finished four experiments and uploaded all model weights to HF.

Overall results

  • results copied from README.md
Model (conf name) EER(%) minDCF Note Huggingface
conf/train_rawnet3_vbClean.yaml 2.51 0.1858 https://huggingface.co/espnet/voxblinkclean_rawnet3
conf/train_rawnet3_vbFull.yaml 2.68 0.1893 https://huggingface.co/espnet/voxblinkfull_rawnet3
conf/train_rawnet3_voxcelebs12devs_voxblinkclean.yaml 0.771 0.0556 https://huggingface.co/espnet/voxcelebs12devs_voxblinkclean_rawnet3
conf/train_rawnet3_voxcelebs12devs_voxblinkfull.yaml 0.782 0.0655 https://huggingface.co/espnet/voxcelebs12devs_voxblinkfull_rawnet3

I believe it's ready to be merged :) Thank you.

@Jungjee Jungjee closed this Jan 4, 2024
@Jungjee Jungjee reopened this Jan 4, 2024
@Jungjee Jungjee closed this Jan 4, 2024
@Jungjee Jungjee reopened this Jan 4, 2024
sw005320
sw005320 reviewed Jan 4, 2024
View reviewed changes
@sw005320 sw005320 added the auto-merge Enable auto-merge label Jan 4, 2024
@sw005320
Copy link
Contributor

sw005320 commented Jan 4, 2024

Thanks a lot!
After the CI check, I’ll merge this PR.

@mergify mergify bot merged commit e8a3195 into espnet:master Jan 4, 2024
@Jungjee Jungjee deleted the voxblink_spk branch January 4, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sw005320 sw005320 sw005320 left review comments

Assignees

No one assigned

Labels

auto-merge Enable auto-merge ESPnet2 README Recipe SID Speaker identification/embedding

Projects

None yet

Milestone

v.202312

Development

Successfully merging this pull request may close these issues.

2 participants

@Jungjee @sw005320