Thanks to visit codestin.com
Credit goes to github.com

Skip to content

E721#5589

Merged
Emrys365 merged 7 commits intomasterfrom
sw005320-patch-1
Dec 13, 2023
Merged

E721#5589
Emrys365 merged 7 commits intomasterfrom
sw005320-patch-1

Conversation

@sw005320
Copy link
Contributor

What?

E721

Why?

Solve the CI issues

@mergify mergify bot added the ESPnet1 label Dec 12, 2023
@mergify mergify bot added the ESPnet2 label Dec 12, 2023
@sw005320 sw005320 added the CI Travis, Circle CI, etc label Dec 12, 2023
@sw005320 sw005320 added this to the v.202312 milestone Dec 12, 2023
@sw005320 sw005320 requested a review from Emrys365 December 12, 2023 22:14
@codecov
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (a4c5547) 0.00% compared to head (712c1f0) 76.54%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5589       +/-   ##
===========================================
+ Coverage        0   76.54%   +76.54%     
===========================================
  Files           0      720      +720     
  Lines           0    66602    +66602     
===========================================
+ Hits            0    50981    +50981     
- Misses          0    15621    +15621     
Flag Coverage Ξ”
test_configuration_espnet2 βˆ… <ΓΈ> (?)
test_integration_espnet1 62.92% <100.00%> (?)
test_integration_espnet2 50.10% <40.00%> (?)
test_python_espnet1 19.08% <40.00%> (?)
test_python_espnet2 52.39% <80.00%> (?)
test_utils 22.15% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@sw005320
Copy link
Contributor Author

@Emrys365, can you review it?
I think the changes would be OK, but I want to make sure.

@sw005320
Copy link
Contributor Author

@Emrys365, if it is OK, please merge this PR.

@Emrys365
Copy link
Collaborator

They look good to me! I will merge it.

@Emrys365 Emrys365 merged commit 0396c45 into master Dec 13, 2023
@Emrys365 Emrys365 deleted the sw005320-patch-1 branch December 13, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix CI Travis, Circle CI, etc ESPnet1 ESPnet2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants