Fixed bug by copying missing Kaldi scripts#5636
Merged
mergify[bot] merged 2 commits intoespnet:masterfrom Jan 29, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5636 +/- ##
=======================================
Coverage 76.15% 76.15%
=======================================
Files 743 743
Lines 69117 69117
=======================================
Hits 52635 52635
Misses 16482 16482
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
Thanks a lot! |
Author
Author
|
Previous CI bug seems to be fixed with the latest commit. Thank you! Another unrelated error seems to apper in CI, this time while executing a HTTP request related to vits :(. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Two scripts where added (
egs2/TEMPLATE/asr1/utils/data/modify_speaker_info.shandegs2/TEMPLATE/asr1/utils/data/internal/modify_speaker_info.py) by copying them from Kaldi's github:https://github.com/kaldi-asr/kaldi/tree/21ae411fd46282726d893e53c05fef5baea64fef/egs/wsj/s5/utils/data
Why?
The recipe failed when using espnet
run.shbecauseegs2/TEMPLATE/asr1/utils/data/modify_speaker_info.shwas missing. This script is a Kaldi script and, by doing a quick search in the espnet repository appears to be used in the espnet recipes for tedlium3, ami, chime6 and tedlium2.The other script,
egs2/TEMPLATE/asr1/utils/data/internal/modify_speaker_info.py, was added since it was required by the first one.