CHiME-8 DASR recipe based on CHiME-7 DASR baseline#5641
CHiME-8 DASR recipe based on CHiME-7 DASR baseline#5641sw005320 merged 67 commits intoespnet:masterfrom
Conversation
for more information, see https://pre-commit.ci
# Conflicts: # egs2/chime8_task1/asr1/local/da_wer_scoring.py
for more information, see https://pre-commit.ci
|
Please let us know if this PR is ready for review. |
|
Will do, I am training a new model based on e-branchformer now. |
| asr_tag="$(basename "${asr_config}" .yaml)_raw" | ||
| asr_exp="exp/asr_${asr_tag}" | ||
| fi | ||
| inference_tag="$(basename "${inference_config}" .yaml)" |
There was a problem hiding this comment.
This is currently failing BTW.
basically due to bash overriding the learning rate and batch size the name of the trained model will be different than the name of the YAML file.
Is there a way to set the name for the ASR model folder ? @simpleoier
There was a problem hiding this comment.
As we discussed, this is due to the difference of asr_tag here in this file and asr.sh.
simpleoier
left a comment
There was a problem hiding this comment.
You may add chime7 and chime8 in egs2/README.md.
| - espnet version: `espnet 202301` | ||
| - pytorch version: `pytorch 1.13.1` | ||
| - Git hash: `89ebca463c544dfaa19e5f76ad5f615f473f6957` | ||
| - Commit date: `Tue Mar 7 04:02:43 2023 +0000` |
There was a problem hiding this comment.
you may put the pretrained checkpoint here.
There was a problem hiding this comment.
Please do that in the follow-up PR then.
There was a problem hiding this comment.
We don't need that it is in HF the model
There was a problem hiding this comment.
Is it possible to rename this result file (from the script)? *.log is not a good name sometimes.
In addition, there are some information related to your own cluster.
There was a problem hiding this comment.
Yes we can rename into txt
There was a problem hiding this comment.
Was LM used? Maybe this file can be excluded.
There was a problem hiding this comment.
No it was not used
There was a problem hiding this comment.
I prefer to leave it I don't have time to retest everything and find out if it is okay to remove
| asr_tag="$(basename "${asr_config}" .yaml)_raw" | ||
| asr_exp="exp/asr_${asr_tag}" | ||
| fi | ||
| inference_tag="$(basename "${inference_config}" .yaml)" |
There was a problem hiding this comment.
As we discussed, this is due to the difference of asr_tag here in this file and asr.sh.
There was a problem hiding this comment.
It is still chime-7 written in this file.
There was a problem hiding this comment.
I moved README.md and changed it
|
This is ready. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
simpleoier
left a comment
There was a problem hiding this comment.
I left some minor comments. I think this PR looks good to me. Thanks!
egs2/chime8_task1/asr1/README.md
Outdated
|
|
||
| Such baseline system would rank third on dev set based on the rules of the past CHiME-6 Challenge | ||
| on Track 1 (unconstrained LM). | ||
| Results on the evaluation set will be released after the end of the CHiME-7 DASR Challenge. <br> |
There was a problem hiding this comment.
Should this description be updated?
There was a problem hiding this comment.
Yes thanks ! i removed this file actually
| if __name__ == "__main__": | ||
| parser = argparse.ArgumentParser( | ||
| "This script is used for scoring according to the procedure outlined in" | ||
| " CHiME-7 DASR challenge website" |
There was a problem hiding this comment.
It's in chime-8 folder and the website points to latest challenge. But it should be fine.
There was a problem hiding this comment.
It is okay this is not used anymore for scoring
There was a problem hiding this comment.
but people may want still to use it
|
@sw005320 let's merge this |
|
I have improved a bit the results: |
There was a problem hiding this comment.
Is it based on the markdown?
There was a problem hiding this comment.
Thanks Shinji, these were there by error. I removed them.
I need to update here the logs with oracle diarization (currently running).
There was a problem hiding this comment.
Will you change it to simply download chime6 from openslr in the future?
There was a problem hiding this comment.
I can remove this.
The download is done via chime-utils now
There was a problem hiding this comment.
Should we remove or should we keep it?
There was a problem hiding this comment.
I think it is better to keep the scoring logs
There was a problem hiding this comment.
Yes it is better to report also cpWER
|
I removed the files @simpleoier merge it as it is approved |
|
The PR passed major CI tests. So, I merged it. |
The idea is to also update CHiME-7 DASR baseline to work for CHiME-8 DASR challenge.
We can then use it for the new challenge paper and also some participants would like maybe to use ESPNet.