ESPnet-SPK: add SdSV 2021 recipe#5659
Conversation
for more information, see https://pre-commit.ci
|
Thanks, @Alexgichamba! @Jungjee, can you review this PR? |
Hi @sw005320 |
Jungjee
left a comment
There was a problem hiding this comment.
Added a few minor comments, lgtm in general.
Thanks for your effort Alex :-)
| @@ -0,0 +1,44 @@ | |||
| # generate_trial_file.py | |||
There was a problem hiding this comment.
can you add a random seed to make it reproducible?
There was a problem hiding this comment.
Could you kindly show me what part of this would be random/irreproducible? The trials are from all the combinations, not a sub sample.
| wav_list = [] | ||
|
|
||
| with open(input_file, "r") as f: | ||
| paths = f.read().splitlines() |
There was a problem hiding this comment.
is it different to paths = f.readlines()?
There was a problem hiding this comment.
Yeah, slightly. It removes the newline.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5659 +/- ##
=======================================
Coverage 76.12% 76.12%
=======================================
Files 744 744
Lines 69247 69247
=======================================
Hits 52716 52716
Misses 16531 16531
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Why did you convert flac to wav?
ESPnet can load the flac file.
There was a problem hiding this comment.
I thought it would be better to have all the audio all as wav. Should I skip this conversion step?
There was a problem hiding this comment.
I see.
It is redundant and eats the file space, but at the same time, this would be easy to check.
So, you can keep it.
Co-authored-by: Shinji Watanabe <[email protected]>
|
Thanks, @Alexgichamba! |
What?
Add a spk1 recipe on the SdSV 2021 challenge
Why?
Provide diverse recipes for ESPnet-SPK and contribute a new testing protocol for spk tasks based on the DeepMine sample dataset
See also
https://sdsvc.github.io/