Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix CI Multilingual ST test#5672

Merged
mergify[bot] merged 3 commits intoespnet:masterfrom
Fhrozen:test-ci
Feb 25, 2024
Merged

Fix CI Multilingual ST test#5672
mergify[bot] merged 3 commits intoespnet:masterfrom
Fhrozen:test-ci

Conversation

@Fhrozen
Copy link
Member

@Fhrozen Fhrozen commented Feb 23, 2024

What?

Fix CI Multilingual ST test

Why?

Errors

@sw005320 sw005320 added Bugfix ST Speech translation labels Feb 23, 2024
@sw005320 sw005320 added this to the v.202405 milestone Feb 23, 2024
@sw005320 sw005320 added the auto-merge Enable auto-merge label Feb 23, 2024
@sw005320
Copy link
Contributor

Thanks a lot, @Fhrozen!

@codecov
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.12%. Comparing base (2aa734d) to head (d891013).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5672      +/-   ##
==========================================
+ Coverage   71.07%   76.12%   +5.05%     
==========================================
  Files         746      747       +1     
  Lines       69369    69409      +40     
==========================================
+ Hits        49301    52836    +3535     
+ Misses      20068    16573    -3495     
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 62.92% <ø> (ø)
test_integration_espnet2 48.92% <ø> (?)
test_python_espnet1 18.32% <ø> (ø)
test_python_espnet2 52.70% <ø> (ø)
test_utils 22.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sw005320
Copy link
Contributor

Thanks, @Fhrozen!
We still seem to have an issue in CI.
https://github.com/espnet/espnet/actions/runs/8019867384/job/21908507343?pr=5672
Can you check this?

@Fhrozen
Copy link
Member Author

Fhrozen commented Feb 25, 2024

@sw005320 I already test and find that the issue is the jsondiff version. I tested with the latest jsondiff and the issue is gone. I will commit and for checking and confirm its PR.

@mergify mergify bot added the Installation label Feb 25, 2024
@mergify mergify bot merged commit 7928d97 into espnet:master Feb 25, 2024
@Fhrozen Fhrozen deleted the test-ci branch March 1, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Enable auto-merge Bugfix Installation ST Speech translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants