Update egs2/TEMPLATE/asr2/asr2.sh#5682
Merged
mergify[bot] merged 3 commits intoespnet:masterfrom Feb 27, 2024
Merged
Conversation
Contributor
|
Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5682 +/- ##
==========================================
+ Coverage 71.07% 76.12% +5.05%
==========================================
Files 746 747 +1
Lines 69369 69409 +40
==========================================
+ Hits 49301 52836 +3535
+ Misses 20068 16573 -3495
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b61968c to
bcb5fbf
Compare
d4aea63 to
36165bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updating the asr2.sh, filtering utterances at stage 4, and moving kmeans step after it, to stage 5.
In the previous script, filtering was done after kmeans, in stage 6. It only removes the utterances with 0-length in the target text. Now I make the filtering step as stage 4, taking into consideration of both wav length and target text length. The previous stage 6 is no longer needed.
Why?
asr2.sh suffers from the too short / long utterances in kmeans pseudo-labeling step, because no filtering was done before kmeans.