Merged
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
simpleoier
approved these changes
Mar 15, 2024
Collaborator
simpleoier
left a comment
There was a problem hiding this comment.
Thanks a lot! This is a lot of effort!
There is one typo in the PR.
I think this should be good if it passes the CI tests.
espnet2/uasr/espnet_model.py
Outdated
| @typechecked | ||
| def number_updates(self, iiter: int): | ||
| assert check_argument_types() and iiter >= 0 | ||
| iiter >= 0 |
Collaborator
There was a problem hiding this comment.
This might not work without assert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
typeguardcheck_argument_types()to the beginning of the function and renamed as@typecheckedcheck_return_typeby assuming that@typecheckedcan cover it.Why?
There are several requests to update
typeguardSee also
#5701
#5660
#5009