Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding transformer_opt#5709

Merged
mergify[bot] merged 4 commits intoespnet:masterfrom
soumimaiti:pr_voxtlm
Mar 20, 2024
Merged

Adding transformer_opt#5709
mergify[bot] merged 4 commits intoespnet:masterfrom
soumimaiti:pr_voxtlm

Conversation

@soumimaiti
Copy link
Contributor

@soumimaiti soumimaiti commented Mar 19, 2024

What?

Adding huggingface transformer opt model to voxtlm_v1

Why?

Huggingface transformer opt model requires additional lm model file to matcha names

See also

Transformer with opt models can be used with transformer_opt

@mergify mergify bot added the ESPnet2 label Mar 19, 2024
@sw005320 sw005320 added this to the v.202405 milestone Mar 19, 2024
@sw005320 sw005320 added the LM label Mar 19, 2024
@codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.35211% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 76.61%. Comparing base (4162159) to head (d2ec3b6).

Files Patch % Lines
espnet2/lm/huggingface_pretrained_opt_lm.py 23.52% 52 Missing ⚠️
espnet2/tasks/lm.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5709      +/-   ##
==========================================
- Coverage   76.66%   76.61%   -0.06%     
==========================================
  Files         760      761       +1     
  Lines       69804    69875      +71     
==========================================
+ Hits        53516    53534      +18     
- Misses      16288    16341      +53
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 62.92% <ø> (ø)
test_integration_espnet2 48.85% <25.35%> (-0.04%) ⬇️
test_integration_espnetez 27.98% <25.35%> (-0.01%) ⬇️
test_python_espnet1 18.21% <0.00%> (-0.02%) ⬇️
test_python_espnet2 52.41% <25.35%> (-0.03%) ⬇️
test_python_espnetez 13.95% <23.94%> (+0.01%) ⬆️
test_utils 20.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sw005320
Copy link
Contributor

sw005320 commented Mar 19, 2024

@wyh2000, can you review this PR?

@wyh2000
Copy link
Contributor

wyh2000 commented Mar 19, 2024

I checked these two updated files, and they look good! I noticed that there is no config file corresponding to the OPT pretrained model in the egs2/voxtlm_v1/lm1/conf folder. It might be better to include configuration files for these models.

@sw005320
Copy link
Contributor

sw005320 commented Mar 19, 2024

I checked these two updated files, and they look good! I noticed that there is no config file corresponding to the OPT pretrained model in the egs2/voxtlm_v1/lm1/conf folder. It might be better to include configuration files for these models.

Thanks!
Yes, it's better to add them.
@soumimaiti, can you do it?

@sw005320 sw005320 added the auto-merge Enable auto-merge label Mar 20, 2024
@mergify mergify bot merged commit ca7716f into espnet:master Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge Enable auto-merge ESPnet2 LM

Projects

None yet

Milestone

v.202409

Development

Successfully merging this pull request may close these issues.

3 participants

@soumimaiti @sw005320 @wyh2000