Adding Hifitts recipe for espnet#5784
Conversation
|
@ftshijt, can you review this PR? |
ftshijt
left a comment
There was a problem hiding this comment.
Please also remember to add your corpus to egs2/README.md
| @@ -0,0 +1,187 @@ | |||
| # This configuration is for ESPnet2 to train 44.1 kHz | |||
There was a problem hiding this comment.
Please only PR the config related to this recipe (usually start with a single best config would be sufficient)
egs2/hifitts/tts1/run.sh
Outdated
| fs=24000 | ||
| n_fft=2048 | ||
| n_shift=300 | ||
| win_length=1200 | ||
|
|
||
| opts= | ||
| if [ "${fs}" -eq 48000 ]; then | ||
| # To suppress recreation, specify wav format | ||
| opts="--audio_format wav " | ||
| else | ||
| opts="--audio_format flac " | ||
| fi |
There was a problem hiding this comment.
I saw that in the readme you said the recipe is for 22.05kHz setup, but the default fs is set to 24000 and 48000 (for raw waveform)? which seems to be a conflict
8ca55cd to
6668ab9
Compare
|
I have made the changes mentioned. Please have a look. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5784 +/- ##
==========================================
+ Coverage 28.12% 28.15% +0.02%
==========================================
Files 544 544
Lines 46233 46254 +21
==========================================
+ Hits 13005 13023 +18
- Misses 33228 33231 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
egs2/hifitts/tts1/run.sh
Outdated
| win_length=null | ||
|
|
||
| opts= | ||
| if [ "${fs}" -eq 48000 ]; then |
There was a problem hiding this comment.
| if [ "${fs}" -eq 48000 ]; then | |
| if [ "${fs}" -eq 44100 ]; then |
According to the openslr page, the highest sampling rate is 44100 for suppressing wav recreation.
|
LGTM! thanks for your contribution. Could you please also fix the CI errors? After that, this PR shall be ready for merge |
|
The CI checks on Ubuntu seem to be failing at egs2/asvspoof/spk1/run.sh . Is there something I must do to fix this? |
|
Thanks for your contribution! The current PR looks good to me~ |
Hi-Fi TTS Recipe for Espnet.