Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SVS] Add CI tests for VISinger Plus#5786

Merged
mergify[bot] merged 7 commits intoespnet:masterfrom
jerryuhoo:hubert
May 30, 2024
Merged

[SVS] Add CI tests for VISinger Plus#5786
mergify[bot] merged 7 commits intoespnet:masterfrom
jerryuhoo:hubert

Conversation

@jerryuhoo
Copy link
Contributor

What?

Add CI tests for VISinger Plus @ftshijt

@mergify mergify bot added the ESPnet2 label May 24, 2024
@jerryuhoo jerryuhoo changed the title Add CI tests for VISinger Plus [SVS] Add CI tests for VISinger Plus May 24, 2024
@ftshijt ftshijt self-requested a review May 24, 2024 18:04
@ftshijt ftshijt added CI Travis, Circle CI, etc Music Music processing labels May 24, 2024
@ftshijt ftshijt added this to the v.202405 milestone May 24, 2024
@ftshijt
Copy link
Collaborator

ftshijt commented May 24, 2024

Hi, many thanks for the update! SInce the new updates also include the post_frontend (espnet2/gan_svs/post_frontend), please also add test for them (you can follow the existing asr test examples)

@codecov
Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 11.76471% with 105 lines in your changes are missing coverage. Please review.

Project coverage is 54.67%. Comparing base (7080bb2) to head (85724f1).

Files Patch % Lines
espnet2/gan_svs/espnet_model.py 1.01% 98 Missing ⚠️
espnet2/bin/svs_inference.py 60.00% 4 Missing ⚠️
espnet2/gan_svs/vits/vits.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5786      +/-   ##
==========================================
- Coverage   59.17%   54.67%   -4.50%     
==========================================
  Files         772      772              
  Lines       70651    70958     +307     
==========================================
- Hits        41808    38797    -3011     
- Misses      28843    32161    +3318     
Flag Coverage Δ
test_integration_espnet2 ?
test_python_espnet2 53.05% <11.76%> (+0.38%) ⬆️
test_utils 20.86% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ftshijt
Copy link
Collaborator

ftshijt commented May 30, 2024

LGTM! Will merge it after the c checks

@ftshijt ftshijt added the auto-merge Enable auto-merge label May 30, 2024
@mergify mergify bot merged commit 30f84fb into espnet:master May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Enable auto-merge CI Travis, Circle CI, etc ESPnet2 Music Music processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants