Merged
Conversation
… of data preparation in egs2/urgent24/enh1; Add an arugment to specify the output audio format in espnet2/bin/enh_inference.py and espnet2/bin/enh_inference_streaming.py
…to support --output_format
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5825 +/- ##
==========================================
+ Coverage 62.62% 62.64% +0.02%
==========================================
Files 153 153
Lines 17008 17017 +9
==========================================
+ Hits 10651 10661 +10
+ Misses 6357 6356 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
@LiChenda, can you review this PR? |
Contributor
Sure! |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR updates several speech enhancement related functions in ESPnet:
--output_formatto specify the output audio format inespnet2/bin/enh_inference.pyandespnet2/bin/enh_inference_streaming.py. Previously the output format is always ".wav".--download_modelwill work as expected.Why?
The updates enhance the SE functionalities in ESPnet.
See also