Conversation
1) update README.md in svs1 2) fix f0max in svs.sh 3) update train_config in opencpop, include rnn_dp, xiaoicesing, singing_tactron
1) natsume: fix score_scp.py to deal with tempo with playback only 2) namine: reconstruct recipe and fix data.sh to use local/prep_segments.py
1) fix variable error in svs.sh 2) fix data preparation in itako
for more information, see https://pre-commit.ci
|
Do these PRs change the results? |
These PRs will not change the model results. Previously, when running these models, we modified the model parameters to those in the current PR to adapt the specific recipe. This time, we have changed these settings to be the default settings. |
|
Got it. |
ftshijt
left a comment
There was a problem hiding this comment.
Thanks for the update! I've left my comments as follows:
| @@ -1 +1 @@ | |||
| ../asr1/db.sh No newline at end of file | |||
| ../../TEMPLATE/asr1/db.sh No newline at end of file | |||
There was a problem hiding this comment.
This link seems identical to its original setting?
| # Only used for the model using pitch features (e.g. FastSpeech2) | ||
| f0min=80 # Maximum f0 for pitch extraction. | ||
| f0max=800 # Minimum f0 for pitch extraction. | ||
| f0max=810 # Minimum f0 for pitch extraction. |
There was a problem hiding this comment.
Do we have some reasons to change this one?
| tempo = None | ||
| for item in m: | ||
| tempo_number = item[2].number | ||
| if tempo_number is not None: | ||
| tempo = tempo_number | ||
| break | ||
| tempo = int(tempo) |
There was a problem hiding this comment.
Is it okay to use only one tempo for all music score object?
1) update opencpop run.sh to provide setting in fs=24000 and fs=44100 2) fix conf in namine 3) update itako version
…pnet into espnet-muskits
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5851 +/- ##
==========================================
- Coverage 54.88% 54.33% -0.55%
==========================================
Files 776 777 +1
Lines 71428 71468 +40
==========================================
- Hits 39203 38834 -369
- Misses 32225 32634 +409
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for the update! LGTM now |
|
Thanks, @South-Twilight! |
What?
Why?
fix bugs as shown above