Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix tts.sh path in aishell3 tts2#5879

Merged
sw005320 merged 2 commits intomasterfrom
sw005320-patch-1
Aug 29, 2024
Merged

Fix tts.sh path in aishell3 tts2#5879
sw005320 merged 2 commits intomasterfrom
sw005320-patch-1

Conversation

@sw005320
Copy link
Contributor

@sw005320 sw005320 commented Aug 28, 2024

@sw005320 sw005320 added this to the v.202405 milestone Aug 28, 2024
@sw005320 sw005320 added the TTS Text-to-speech label Aug 28, 2024
@mergify mergify bot added the ESPnet2 label Aug 28, 2024
@codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.46%. Comparing base (7b44d96) to head (a80c5bf).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5879      +/-   ##
==========================================
+ Coverage   27.91%   30.46%   +2.54%     
==========================================
  Files         551      820     +269     
  Lines       47587    75420   +27833     
==========================================
+ Hits        13284    22976    +9692     
- Misses      34303    52444   +18141
Flag Coverage Δ
test_integration_espnet1 62.56% <ø> (?)
test_integration_espnetez 27.86% <ø> (-0.05%) ⬇️
test_python_espnetez 13.37% <ø> (?)
test_utils 20.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tsukasane
Copy link
Contributor

Tsukasane commented Aug 28, 2024

Sorry for the absolute path in my original PR! I checked the file changes there and found other three absolute paths(all from symlink, under aishell3/tts2/local/). Sorry again for my negligence. Do you want me to fix them also by creating PR to this patch branch?

@sw005320 sw005320 added the auto-merge Enable auto-merge label Aug 28, 2024
@sw005320 sw005320 merged commit 7750626 into master Aug 29, 2024
@sw005320 sw005320 deleted the sw005320-patch-1 branch August 29, 2024 11:00
@sw005320
Copy link
Contributor Author

sw005320 commented Aug 29, 2024

Sorry for the absolute path in my original PR! I checked the file changes there and found other three absolute paths(all from symlink, under aishell3/tts2/local/). Sorry again for my negligence. Do you want me to fix them also by creating PR to this patch branch?

no problem. it is easy to fix

@Tsukasane
Copy link
Contributor

Tsukasane commented Aug 29, 2024

no problem. it is easy to fix

Okay, I have updated the fixing in PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge Enable auto-merge ESPnet2 TTS Text-to-speech

Projects

None yet

Milestone

v.202409

Development

Successfully merging this pull request may close these issues.

2 participants

@sw005320 @Tsukasane