Fixed SingingGenerate docstring examples#5889
Merged
ftshijt merged 5 commits intoespnet:masterfrom Sep 4, 2024
Merged
Conversation
Collaborator
|
Looks great! Will merge it after CI fixed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5889 +/- ##
===========================================
+ Coverage 30.49% 62.56% +32.06%
===========================================
Files 819 153 -666
Lines 75453 17065 -58388
===========================================
- Hits 23007 10676 -12331
+ Misses 52446 6389 -46057
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Shikhar-S
pushed a commit
to Shikhar-S/espnet
that referenced
this pull request
Mar 13, 2025
Fixed SingingGenerate docstring examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updated docstring examples for SingingGenerate.
Why?
The original docstring examples were intended for TTS (Text-to-Speech) inference and were not applicable to SVS (Singing Voice Synthesis) inference, leading to potential confusion for users. This update corrects the examples to reflect proper usage for SVS inference.
See also
N/A