Merged
Conversation
ftshijt
commented
Sep 12, 2024
|
|
||
| elif modality in ["text_bpe"]: | ||
| writers[name].write(f"{example_name} {detokenized}") | ||
| detokenized = detokenized.strip() |
Collaborator
Author
There was a problem hiding this comment.
@jctian98 Please let me know if this is fixed in your latest PR then I can remove this temporary modification.
| --inference_nj ${inference_nj} \ | ||
| --gpu_inference ${gpu_inference} \ | ||
| --nbest ${nbest} | ||
| --nbest ${nbest} ${scoring_args} |
Collaborator
Author
There was a problem hiding this comment.
@jctian98 I intentionally add this one to incorporate scoring related arguments for different tasks.
Collaborator
Author
|
@jctian98 This is a following up fix for MT task of speechlm project, mostly with evaluation. |
Collaborator
|
it's ok to merge this to speechlm branch for now. I'll take care of the compatibility issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full MT-task implementation for speechlm.