Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bugfix for the paper publish workflow#5909

Merged
sw005320 merged 1 commit intoespnet:masterfrom
juice500ml:bugfix/workflow_depr
Sep 24, 2024
Merged

Bugfix for the paper publish workflow#5909
sw005320 merged 1 commit intoespnet:masterfrom
juice500ml:bugfix/workflow_depr

Conversation

@juice500ml
Copy link
Contributor

What?

Paper publish build is failing

Why?

Github actions' actions/upload-artifact was deprecated.
I bumped up from v1 to v4, because it doesn't seem to have difference in the interface.

See also

@mergify mergify bot added the CI Travis, Circle CI, etc label Sep 24, 2024
@sw005320 sw005320 added this to the v.202405 milestone Sep 24, 2024
@codecov
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.50%. Comparing base (eac8c1a) to head (b81f30e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5909       +/-   ##
===========================================
+ Coverage   32.05%   45.50%   +13.45%     
===========================================
  Files         820      613      -207     
  Lines       75615    54138    -21477     
===========================================
+ Hits        24235    24635      +400     
+ Misses      51380    29503    -21877     
Flag Coverage Δ
test_integration_espnet2 48.20% <ø> (-0.01%) ⬇️
test_integration_espnetez 27.83% <ø> (?)
test_python_espnetez ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sw005320 sw005320 merged commit e574f8e into espnet:master Sep 24, 2024
@sw005320
Copy link
Contributor

Thanks for your quick fixes, @juice500ml!

@juice500ml juice500ml deleted the bugfix/workflow_depr branch September 24, 2024 17:03
Shikhar-S pushed a commit to Shikhar-S/espnet that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Travis, Circle CI, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants