Bugfix for the paper publish workflow#5909
Merged
sw005320 merged 1 commit intoespnet:masterfrom Sep 24, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5909 +/- ##
===========================================
+ Coverage 32.05% 45.50% +13.45%
===========================================
Files 820 613 -207
Lines 75615 54138 -21477
===========================================
+ Hits 24235 24635 +400
+ Misses 51380 29503 -21877
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
Thanks for your quick fixes, @juice500ml! |
Shikhar-S
pushed a commit
to Shikhar-S/espnet
that referenced
this pull request
Mar 13, 2025
Bugfix for the paper publish workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Paper publish build is failing
Why?
Github actions'
actions/upload-artifactwas deprecated.I bumped up from v1 to v4, because it doesn't seem to have difference in the interface.
See also