Minor formatting fixes in mlsuperb 2 recipe#6003
Merged
ftshijt merged 5 commits intoespnet:masterfrom Jan 8, 2025
Merged
Conversation
Contributor
|
Or I can do it if I can find stable internet connections. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6003 +/- ##
===========================================
- Coverage 51.87% 38.18% -13.69%
===========================================
Files 854 565 -289
Lines 80163 50989 -29174
===========================================
- Hits 41584 19472 -22112
+ Misses 38579 31517 -7062
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Thanks! I also just added more documentation about the scoring |
for more information, see https://pre-commit.ci
Shikhar-S
pushed a commit
to Shikhar-S/espnet
that referenced
this pull request
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Changed scoring to better adhere to ESPnet standards.
EDIT: also added more documentation about the scoring