Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Minor formatting fixes in mlsuperb 2 recipe#6003

Merged
ftshijt merged 5 commits intoespnet:masterfrom
wanchichen:master
Jan 8, 2025
Merged

Minor formatting fixes in mlsuperb 2 recipe#6003
ftshijt merged 5 commits intoespnet:masterfrom
wanchichen:master

Conversation

@wanchichen
Copy link
Contributor

@wanchichen wanchichen commented Jan 3, 2025

What?

Changed scoring to better adhere to ESPnet standards.

EDIT: also added more documentation about the scoring

@sw005320 sw005320 added Bugfix Recipe ASR Automatic speech recogntion labels Jan 3, 2025
@sw005320 sw005320 added this to the v.202503 milestone Jan 3, 2025
Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ftshijt, once this PR passes, please merge it.

@sw005320
Copy link
Contributor

sw005320 commented Jan 3, 2025

Or I can do it if I can find stable internet connections.

@codecov
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.18%. Comparing base (de6b526) to head (3683933).
Report is 6 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (de6b526) and HEAD (3683933). Click for more details.

HEAD has 19 uploads less than BASE
Flag BASE (de6b526) HEAD (3683933)
test_python_espnet2 10 0
test_utils 9 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6003       +/-   ##
===========================================
- Coverage   51.87%   38.18%   -13.69%     
===========================================
  Files         854      565      -289     
  Lines       80163    50989    -29174     
===========================================
- Hits        41584    19472    -22112     
+ Misses      38579    31517     -7062     
Flag Coverage Δ
test_integration_espnetez 38.18% <ø> (?)
test_python_espnet2 ?
test_utils ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanchichen
Copy link
Contributor Author

Thanks! I also just added more documentation about the scoring

@ftshijt ftshijt merged commit d205df8 into espnet:master Jan 8, 2025
39 checks passed
Shikhar-S pushed a commit to Shikhar-S/espnet that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants