Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix minor bug in OWSM-CTC preprocessor#6005

Merged
sw005320 merged 1 commit intoespnet:masterfrom
pyf98:owsmctc-test
Jan 5, 2025
Merged

Fix minor bug in OWSM-CTC preprocessor#6005
sw005320 merged 1 commit intoespnet:masterfrom
pyf98:owsmctc-test

Conversation

@pyf98
Copy link
Collaborator

@pyf98 pyf98 commented Jan 4, 2025

What?

During OWSM-CTC training, the language token is randomly masked so that the model will learn to predict it. However, this should not happen for validation.

@mergify mergify bot added the ESPnet2 label Jan 4, 2025
@sw005320 sw005320 added Bugfix OWSM Open Whisper-style Speech Model labels Jan 4, 2025
@sw005320 sw005320 added this to the v.202503 milestone Jan 4, 2025
Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it.
Please merge this PR once the CI test is passed.

@codecov
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.49%. Comparing base (ef6740c) to head (522891b).
Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
espnet2/train/preprocessor.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6005      +/-   ##
==========================================
+ Coverage   47.48%   47.49%   +0.01%     
==========================================
  Files         529      529              
  Lines       47850    47850              
==========================================
+ Hits        22721    22727       +6     
+ Misses      25129    25123       -6     
Flag Coverage Δ
test_integration_espnet2 47.49% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sw005320 sw005320 merged commit de6b526 into espnet:master Jan 5, 2025
38 of 39 checks passed
@pyf98 pyf98 deleted the owsmctc-test branch January 5, 2025 19:08
Shikhar-S pushed a commit to Shikhar-S/espnet that referenced this pull request Mar 13, 2025
Fix minor bug in OWSM-CTC preprocessor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix ESPnet2 OWSM Open Whisper-style Speech Model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants