fix some minor errors in SID recipe#6045
Conversation
|
Thanks! @Jungjee, can you take a look at them? |
Jungjee
left a comment
There was a problem hiding this comment.
Thanks for pointing out the corner case in RIR augmentation configuration!
Can you revert the one line change in spk.sh? Other than that, LGTM!
egs2/TEMPLATE/spk1/spk.sh
Outdated
| --data_path_and_name_and_type ${_inference_dir}/trial2.scp,speech2,sound \ | ||
| --data_path_and_name_and_type ${_inference_dir}/trial_label,spk_labels,text \ | ||
| --shape_file ${spk_stats_dir}/valid/speech_shape \ | ||
| --shape_file ${spk_stats_dir}/test/speech_shape \ |
There was a problem hiding this comment.
Thanks, @shimhz, but can you revert this line?
I get where this is coming from, but I think this would better be dealt in another PR with other changes (which I'll need to work on sometime soon..)
There was a problem hiding this comment.
I understand what you mean. I reverted that line.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6045 +/- ##
==========================================
+ Coverage 38.19% 47.44% +9.25%
==========================================
Files 566 531 -35
Lines 51080 48030 -3050
==========================================
+ Hits 19511 22789 +3278
+ Misses 31569 25241 -6328
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@shimhz, Can you check this? |
for more information, see https://pre-commit.ci
|
Thanks, @shimhz! |
fix some minor errors in SID recipe
What?
Minor fixes for SID recipe
Why?
See also