A quick fix for type error when dealing with multi-decoder (ST)#6064
Merged
sw005320 merged 8 commits intoespnet:masterfrom Mar 17, 2025
Merged
A quick fix for type error when dealing with multi-decoder (ST)#6064sw005320 merged 8 commits intoespnet:masterfrom
sw005320 merged 8 commits intoespnet:masterfrom
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6064 +/- ##
===========================================
+ Coverage 12.80% 38.20% +25.39%
===========================================
Files 868 566 -302
Lines 81221 51090 -30131
===========================================
+ Hits 10404 19518 +9114
+ Misses 70817 31572 -39245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks, @ftshijt! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the latest typeguard, it will spot the type issue in multi-decoder decoding (when both ASR and ST search are returned together).
Adding a simple fix to allow a tuple type for the multi-decoder return cases.
(Noted that this fix is necessary to make sure the demonstration notebook is working smoothly)