Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Downgrade Transformers version#6071

Merged
sw005320 merged 4 commits intoespnet:masterfrom
Fhrozen:pr-ver
Mar 26, 2025
Merged

Downgrade Transformers version#6071
sw005320 merged 4 commits intoespnet:masterfrom
Fhrozen:pr-ver

Conversation

@Fhrozen
Copy link
Member

@Fhrozen Fhrozen commented Mar 25, 2025 •
edited
Loading

What?

Limit max version of Transformers

Why?

The current version of transformer 4.50.0, seems to be developed for newest pytorch versions (>=2.3.0)

@mergify mergify bot added the Installation label Mar 25, 2025
@Fhrozen
Copy link
Member Author

Fhrozen commented Mar 25, 2025

Planned to fix #6067

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.39%. Comparing base (5377695) to head (aa52af6).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #6071       +/-   ##
===========================================
+ Coverage   14.48%   62.39%   +47.91%     
===========================================
  Files         875      153      -722     
  Lines       81925    17124    -64801     
===========================================
- Hits        11863    10684     -1179     
+ Misses      70062     6440    -63622
Flag Coverage Δ
test_integration_espnet1 62.39% <ø> (?)
test_python_espnetez ?
test_utils ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sw005320 sw005320 added this to the v.202503 milestone Mar 25, 2025
@sw005320 sw005320 merged commit e72ffd9 into espnet:master Mar 26, 2025
38 checks passed
@sw005320
Copy link
Contributor

sw005320 commented Mar 26, 2025

Thanks @Fhrozen!

@Fhrozen Fhrozen deleted the pr-ver branch March 26, 2025 12:28
Vaibhavs10
Vaibhavs10 reviewed Mar 26, 2025
View reviewed changes
Copy link

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey hey - https://github.com/huggingface/transformers/releases (4.50.1) should fix this, so you should not need it.

@sw005320
Copy link
Contributor

sw005320 commented Mar 26, 2025

Thanks, @Vaibhavs10!
@Fhrozen, can you remove the version restriction?

@Fhrozen
Copy link
Member Author

Fhrozen commented Mar 26, 2025

Version 4.50.1 fixes the flatten_with_keys_fn import error. So, I suppose that pytorch versions higher than 2.0.0, should not have that issue. But, for 1.13, the restriction is needed, because it does not have a the compiler folder.
I will check again and test if no issue is presented when the restriction is removed.

@sw005320
Copy link
Contributor

sw005320 commented Mar 26, 2025

Maybe, we can remove the CI support for 1.13 in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Vaibhavs10 Vaibhavs10 Vaibhavs10 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bugfix Installation

Projects

None yet

Milestone

v.202503

Development

Successfully merging this pull request may close these issues.

3 participants

@Fhrozen @sw005320 @Vaibhavs10