Update BSRNN implementations to support more flexible band-split schemes#6123
Merged
sw005320 merged 5 commits intoespnet:masterfrom Jun 10, 2025
Merged
Update BSRNN implementations to support more flexible band-split schemes#6123sw005320 merged 5 commits intoespnet:masterfrom
sw005320 merged 5 commits intoespnet:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6123 +/- ##
==========================================
- Coverage 44.47% 37.84% -6.63%
==========================================
Files 581 570 -11
Lines 54199 51924 -2275
==========================================
- Hits 24106 19652 -4454
- Misses 30093 32272 +2179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks, @Emrys365! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the BSRNN implementation to add support of more band-split schemes (e.g., overlapping mel subbands).
In addition, this PR also adds checks of the
norm_typeargument to prevent unintended use whencausal=True.Why?
This should benefit future model designs and may bring some performance gains.