Codestin Search App

Qingzheng-Wang · 2025-06-19T05:32:34Z

What did you change?

This PR introduces the core training and evaluation pipeline for the LID task in ESPnet, including:

espnet2/bin/lid_train.py: training entry point
espnet2/tasks/lid.py: task definition
- Note: The full espnet2/tasks/lid.py are split into three parts in three PRs:
  - LID-1 (this): LID preprocessor integration only.
  - LID-2: Model, loss and pooling modules #6156 : LID model integration only.
  - LID-3: Inference, embedding extraction and t-SNE visualization #6157 : LID trainer integration only.
espnet2/train/preprocessor.py: updated to support LID-specific preprocessing

Why did you make this change?

This is the foundational step to enable language identification (LID) training within ESPnet. It defines the task and enables downstream LID model training.

Is your PR small enough?

Yes

Additional Context

Part 1 of the LID system.
Depends on:

for more information, see https://pre-commit.ci

sw005320 · 2025-06-19T11:32:17Z

This pull request introduces significant enhancements to the espnet2 framework, including new batch sampling strategies, additional arguments for batch configuration, and a specialized preprocessor for Language Identification (LID) tasks. These changes improve flexibility in data handling and expand functionality for specific use cases.

Batch Sampling Enhancements:

Added two new batch samplers, CategoryPowerSampler and CategoryDatasetPowerSampler, to support advanced sampling strategies for low-resource categories and datasets.
Introduced new arguments (--upsampling_factor, --language_upsampling_factor, --dataset_upsampling_factor, --dataset_scaling_factor, and --max_batch_size) for configuring batch sampling, particularly for the new samplers.
Updated the build_category_iter_factory method to implement logic for the new batch types (catpow and catpow_balance_dataset) and added error handling for missing required files (dataset2utt and utt2dataset). [1] [2] [3]

Scheduler Integration:

Added TristageLR to the list of supported learning rate schedulers, enabling more complex learning rate adjustments during training.

Preprocessor for LID Tasks:

Introduced the LIDPreprocessor class, which provides specialized preprocessing for Language Identification tasks, including duration fixing, noise augmentation, and label mapping based on lang2utt files.

Copilot

Pull Request Overview

Adds foundational support for language identification (LID) training and evaluation in ESPnet by defining a new preprocessor and extending task configuration for sampling strategies.

Introduce LIDPreprocessor in espnet2/train/preprocessor.py
Integrate new samplers and schedulers in espnet2/tasks/abs_task.py
Expose CLI arguments for CategoryPowerSampler and CategoryDatasetPowerSampler

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 4 comments.

File	Description
espnet2/train/preprocessor.py	Add `LIDPreprocessor` class for LID-specific preprocessing
espnet2/tasks/abs_task.py	Import new samplers/schedulers and hook up CLI options

espnet2/train/preprocessor.py

espnet2/tasks/abs_task.py

Co-authored-by: Copilot <[email protected]>

for more information, see https://pre-commit.ci

sw005320 · 2025-06-19T14:53:27Z

@Qingzheng-Wang, can you try to fix the CI errors for all your PRs?

Qingzheng-Wang · 2025-06-19T15:16:15Z

@Qingzheng-Wang, can you try to fix the CI errors for all your PRs?

Yes, I'm fixing them.

for more information, see https://pre-commit.ci

codecov · 2025-06-20T01:01:12Z

Codecov Report

Attention: Patch coverage is 7.80142% with 130 lines in your changes missing coverage. Please review.

Project coverage is 46.52%. Comparing base (d3db636) to head (3c077ef).
Report is 49 commits behind head on master.

Files with missing lines	Patch %	Lines
espnet2/train/preprocessor.py	7.80%	130 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d3db636) and HEAD (3c077ef). Click for more details.

HEAD has 15 uploads less than BASE

Flag BASE (d3db636) HEAD (3c077ef)

test_python_espnet2 7 0

test_utils 7 0

test_integration_espnetez 1 0

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6155      +/-   ##
==========================================
- Coverage   55.45%   46.52%   -8.94%     
==========================================
  Files         882      542     -340     
  Lines       82812    49601   -33211     
==========================================
- Hits        45927    23079   -22848     
+ Misses      36885    26522   -10363

Flag	Coverage Δ
test_integration_espnet2	`46.52% <7.80%> (?)`
test_integration_espnetez	`?`
test_python_espnet2	`?`
test_utils	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sw005320 · 2025-06-20T15:16:24Z

LGTM.
I want to make sure that a test (in the other PRs or follow-up PRs) can go through this change.

Qingzheng-Wang added 4 commits June 19, 2025 01:21

Add lid train entry.

e9adb1e

Add lid and catpow batch sampler support.

6b8a290

Add lid task setup.

ecfe5cd

Add lid trainer.

88f4c2e

dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jun 19, 2025

mergify bot added the ESPnet2 label Jun 19, 2025

dosubot bot added the New Features label Jun 19, 2025

[pre-commit.ci] auto fixes from pre-commit.com hooks

75a5e27

for more information, see https://pre-commit.ci

sw005320 requested a review from Copilot June 19, 2025 11:32

Copilot AI reviewed Jun 19, 2025

View reviewed changes

espnet2/train/preprocessor.py Show resolved Hide resolved

espnet2/train/preprocessor.py Outdated Show resolved Hide resolved

espnet2/train/preprocessor.py Outdated Show resolved Hide resolved

espnet2/tasks/abs_task.py Outdated Show resolved Hide resolved

Qingzheng-Wang and others added 5 commits June 19, 2025 08:20

Update espnet2/train/preprocessor.py

e591c85

Co-authored-by: Copilot <[email protected]>

Update espnet2/train/preprocessor.py

31b3a4c

Co-authored-by: Copilot <[email protected]>

Move changes for catpow samplers and tristagelr to their own prs.

2d73547

Fix LID preprocessor.

864cb70

[pre-commit.ci] auto fixes from pre-commit.com hooks

1847210

for more information, see https://pre-commit.ci

sw005320 added this to the v.202506 milestone Jun 19, 2025

Qingzheng-Wang and others added 4 commits June 19, 2025 11:46

Fix line length.

eff537a

Remove the lid model and lid trainer related.

30ee9bc

[pre-commit.ci] auto fixes from pre-commit.com hooks

c4ecaae

for more information, see https://pre-commit.ci

Remove unused imports.

3c077ef

sw005320 merged commit 3bff1f0 into espnet:master Jun 20, 2025
42 of 69 checks passed

Qingzheng-Wang mentioned this pull request Jun 26, 2025

LID-7: VoxLingua107 recipe #6174

Merged

This was referenced Aug 17, 2025

LID-8: CI and unit tests #6210

Merged

LID-9: Geolocation-aware LID recipe and codes #6212

Open

Fhrozen mentioned this pull request Sep 11, 2025

Version Release #6236

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LID-1: Training and task setup#6155

LID-1: Training and task setup#6155
sw005320 merged 14 commits intoespnet:masterfrom
Qingzheng-Wang:lid_release1

Qingzheng-Wang commented Jun 19, 2025 •

edited

Loading

Uh oh!

sw005320 commented Jun 19, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sw005320 commented Jun 19, 2025

Uh oh!

Qingzheng-Wang commented Jun 19, 2025

Uh oh!

codecov bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

sw005320 commented Jun 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Qingzheng-Wang commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What did you change?

Why did you make this change?

Is your PR small enough?

Additional Context

Uh oh!

sw005320 commented Jun 19, 2025

Batch Sampling Enhancements:

Scheduler Integration:

Preprocessor for LID Tasks:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sw005320 commented Jun 19, 2025

Uh oh!

Qingzheng-Wang commented Jun 19, 2025

Uh oh!

codecov bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sw005320 commented Jun 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Qingzheng-Wang commented Jun 19, 2025 •

edited

Loading

codecov bot commented Jun 20, 2025 •

edited

Loading