Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[espnet3] ESPnet1 Support Sunset and Migration to espnet2.legacy#6179

Merged
Masao-Someki merged 96 commits intoespnet:espnet3from
Masao-Someki:espnet3/farewell_ver1
Sep 15, 2025
Merged

[espnet3] ESPnet1 Support Sunset and Migration to espnet2.legacy#6179
Masao-Someki merged 96 commits intoespnet:espnet3from
Masao-Someki:espnet3/farewell_ver1

Conversation

@Masao-Someki
Copy link
Contributor

What did you change?

  • Removed all ESPnet1-related CI testing, scripts, and references.
  • Deleted ESPnet1 test and integration scripts (test_python_espnet1.sh, test_shell_espnet1.sh, test_integration_espnet1.sh).
  • Removed the espnet package directory and migrated necessary utilities to espnet2.legacy.
  • Adjusted all imports to use espnet2.legacy instead of espnet.
  • Cleaned up CI pipelines to reflect ESPnet2-only support.
  • Updated configuration files, removing init: chainer and replacing it with init: normal.

Why did you make this change?

  • To fully deprecate and remove ESPnet1 support from the repository.
  • To streamline CI/CD pipelines and reduce maintenance overhead.
  • To ensure a unified and modern codebase centered on ESPnet2.
  • To eliminate legacy Chainer-based components which are no longer supported.

Is your PR small enough?

No, but except for the following items, basically all files were updated via simply replacing or copy/paste.

  • Selection of functions/classes.
  • Update beam-search related unit tests to use espnet-2 functions
  • CI fix, chainer removal

We may separate removal of chainer support as another PR to update dependencies.


Additional Context

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2025

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Sep 14, 2025
@mergify mergify bot removed the conflicts label Sep 14, 2025
@Masao-Someki
Copy link
Contributor Author

@sw005320
For ci/test_utils.sh, I reviewed all the bats files and removed the test file that checks files not used in ESPnet-2. Since all bats files for integration tests have been removed, test_utils.sh now only runs unit tests. However, these unit tests were not executed in the original file, so we could consider removing the test_utils.sh process entirely..

Copy link
Contributor

@sw005320 sw005320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me.
You can merge this PR.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 15, 2025
@Masao-Someki Masao-Someki merged commit 7020032 into espnet:espnet3 Sep 15, 2025
29 checks passed
@sw005320
Copy link
Contributor

Cool!
This is a great advance for espnet3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASR Automatic speech recogntion CI Travis, Circle CI, etc Documentation ESPnet1 ESPnet2 Installation lgtm This PR has been approved by a maintainer LM mergify MT Machine translation Refactoring Refactoring size:L This PR changes 100-499 lines, ignoring generated files. TTS Text-to-speech

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants