Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add environment tag to publish docker image#6206

Merged
sw005320 merged 1 commit intoespnet:masterfrom
Fhrozen:pr-docker
Aug 13, 2025
Merged

Add environment tag to publish docker image#6206
sw005320 merged 1 commit intoespnet:masterfrom
Fhrozen:pr-docker

Conversation

@Fhrozen
Copy link
Member

@Fhrozen Fhrozen commented Aug 13, 2025

What

This pull request makes minor corrections to the GitHub Actions workflow for publishing Docker images. The changes address a typo in the workflow name and add an environment specification to the Docker job.

  • Workflow name corrected from "publich docker image" to "publish docker image" for clarity.
  • Added the environment: docker field to the docker job to specify the environment used for publishing Docker images.

@Fhrozen Fhrozen requested a review from Copilot August 13, 2025 01:00
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Docker labels Aug 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes minor corrections to the GitHub Actions workflow for publishing Docker images, fixing a typo in the workflow name and adding environment configuration for better deployment control.

  • Corrected workflow name from "publich docker image" to "publish docker image"
  • Added environment specification to the docker job for deployment environment control

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@mergify mergify bot added the CI Travis, Circle CI, etc label Aug 13, 2025
@sw005320 sw005320 added this to the v.202509 milestone Aug 13, 2025
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.39%. Comparing base (84ea819) to head (3afca9c).
⚠️ Report is 11 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (84ea819) and HEAD (3afca9c). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (84ea819) HEAD (3afca9c)
test_integration_espnetez 8 0
test_python_espnet2 2 0
test_utils 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6206      +/-   ##
==========================================
- Coverage   54.73%   46.39%   -8.34%     
==========================================
  Files         893      546     -347     
  Lines       84227    49880   -34347     
==========================================
- Hits        46098    23140   -22958     
+ Misses      38129    26740   -11389     
Flag Coverage Δ
test_integration_espnet2 46.39% <ø> (?)
test_integration_espnetez ?
test_python_espnet2 ?
test_utils ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sw005320 sw005320 merged commit 50ac856 into espnet:master Aug 13, 2025
46 of 54 checks passed
@Fhrozen Fhrozen deleted the pr-docker branch August 13, 2025 10:22
@Fhrozen Fhrozen mentioned this pull request Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Travis, Circle CI, etc Docker size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants