Update wham_noise link for LibriMix Recipe#6251
Conversation
There was a problem hiding this comment.
Code Review
This pull request correctly identifies and fixes a broken download link for the wham_noise dataset, which is essential for the LibriMix recipe. However, the new URL points to what appears to be a personal or temporary S3 bucket. This introduces a critical risk for the long-term maintainability and reliability of the script. If the bucket is removed, the recipe will break for all future users. I have added a critical review comment recommending that the dataset be hosted in a more permanent and stable location to ensure the recipe's longevity.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6251 +/- ##
=======================================
Coverage 56.77% 56.77%
=======================================
Files 889 889
Lines 84340 84340
=======================================
Hits 47882 47882
Misses 36458 36458
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks, @Fhrozen! |
Fix #6153
What did you change?
Change the link of
wham_noiseto a live link.ref:
https://github.com/JorisCos/LibriMix/blob/master/generate_librimix.sh