Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(board): add support for rakwireless rak3112 #11485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(board): add support for rakwireless rak3112 #11485

wants to merge 6 commits into from
+209 −0

Conversation

DanielCao0
Copy link

@DanielCao0 DanielCao0 commented Jun 19, 2025 •
edited
Loading

This pull request introduces support for the RAKWireless RAK3112 module by adding its configuration to the boards.txt file and defining its pin mappings in pins_arduino.h. The changes primarily focus on enabling compatibility with the RAK3112 hardware and providing the necessary settings for its operation.

RAK3112: ESP32S3+SX1262(LORA)

https://www.rakwireless.com/en-us
https://docs.rakwireless.com/product-categories/wisduo/rak3112-module/overview

New Board Support: RAKWireless RAK3112

Board Configuration:

  • Added a new entry for the RAKWireless RAK3112 in boards.txt, including upload settings, build configurations, and menu options such as PSRAM, core selection, USB mode, partition schemes, CPU frequency, flash mode, and debug levels. [1] [2]

Pin Definitions:

  • Created a new pins_arduino.h file under the variants/rakwireless_rak3112 directory. This file defines the pin mappings for the RAK3112, including USB VID/PID, LED pins, I2C pins, SPI pins, and LoRa module pins.

image

@DanielCao0 DanielCao0 requested a review from P-R-O-C-H-Y as a code owner June 19, 2025 03:12
@CLAassistant
Copy link

CLAassistant commented Jun 19, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 19, 2025 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Delete blank lines":
    • summary looks empty
    • type/action looks empty
  • the commit message "Delete the redundant configuration information in board.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "Move the rak configuration information to the end of the boards.txt .":
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty
  • the commit message "Restore the incorrect modifications to board.txt":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello DanielCao0, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against a8620bc

@DanielCao0 DanielCao0 closed this Jun 19, 2025
@DanielCao0 DanielCao0 reopened this Jun 19, 2025
@DanielCao0 DanielCao0 changed the title Feat/support rakwireless rak3112 Feat/support rakwireless rak3112 Jun 19, 2025
@DanielCao0 DanielCao0 closed this Jun 19, 2025
@DanielCao0 DanielCao0 reopened this Jun 19, 2025
@DanielCao0 DanielCao0 changed the title Feat/support rakwireless rak3112 feat(board): add support for rakwireless rak3112 Jun 19, 2025
@P-R-O-C-H-Y
Copy link
Member

Hi @DanielCao0, please mov the RAK board definitions to the end of the file as there is no other RAK board there. Thanks

@DanielCao0
Copy link
Author

DanielCao0 commented Jun 19, 2025 •
edited
Loading

@P-R-O-C-H-Y Thank you , I have already moved the RAK board definitions to the end of the file as requested.
Please let me know if there’s anything else that needs to be adjusted. Thanks!

P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Jun 19, 2025
View reviewed changes
variants/rakwireless_rak3112/pins_arduino.h
Comment on lines +14 to +15
#define LED_GREEN 46
#define LED_BLUE 45
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask where those pins comes from? I don't see anything in the docs as its only a module.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.rakwireless.com/product-categories/wisblock/rak19010/overview/
This module can be used with a base board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y left review comments

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielCao0 @CLAassistant @P-R-O-C-H-Y @danielRAKwireless