Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add FED4 board #11536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 2, 2025
Merged

Add FED4 board #11536

merged 9 commits into from
Jul 2, 2025

Conversation

strid3r21
Copy link
Contributor

@strid3r21 strid3r21 commented Jul 1, 2025 •
edited
Loading

Adding the FED4 board

Description of Change

Adding the FED4 board pin definitions and to boards.txt.

the FED4 is a small commercial product that university labs can use monitor feeding behaviors of mice.
Designed by my company Smart Bee Designs LLC

FED4
image001

The Fed4 is the next installment in the FED line (replacing the FED3) https://kravitzlab.com/research & https://open-ephys.org/fed3/fed3

Tests scenarios

Tested on 3.2.0 on Windows running through several sketches that functionally test the device.

@strid3r21 strid3r21 requested a review from P-R-O-C-H-Y as a code owner July 1, 2025 21:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Added Fed 4 board":
    • summary looks empty
    • type/action looks empty
  • the commit message "added usb pid address":
    • summary looks empty
    • type/action looks empty
  • the commit message "fixed board.txt again":
    • summary looks empty
    • type/action looks empty
  • the commit message "fixed boards.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "fixed typo: updated name to upper case":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello strid3r21, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 1b2825f

@P-R-O-C-H-Y
Copy link
Member

@strid3r21 the CI is failing, please fix the errors: https://github.com/espressif/arduino-esp32/actions/runs/16010562871/job/45167261247?pr=11536

@P-R-O-C-H-Y P-R-O-C-H-Y added Type: 3rd party Boards Status: Awaiting Response awaiting a response from the author labels Jul 2, 2025
P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Jul 2, 2025
View reviewed changes
P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Jul 2, 2025
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strid3r21 PTAL, also would be best to include some link to the product in the PR description.

@strid3r21
Copy link
Contributor Author

strid3r21 commented Jul 2, 2025 •
edited
Loading

@strid3r21 PTAL, also would be best to include some link to the product in the PR description.

added links.

P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Jul 2, 2025
View reviewed changes
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Awaiting Response awaiting a response from the author labels Jul 2, 2025
@me-no-dev me-no-dev merged commit 33c8438 into espressif:master Jul 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strid3r21 @P-R-O-C-H-Y @me-no-dev