Add set and get commands for ESP RainMaker console (MEGH-6740) #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Infishiv
commented
Jun 11, 2025
| #include <esp_log.h> | ||
| #include <esp_wifi.h> | ||
| #include <esp_console.h> | ||
| #include <string.h> |
There was a problem hiding this comment.
Pull Request Overview
Adds set and get console commands to allow users to modify and retrieve ESP RainMaker device parameters via the console interface.
- Implements
set_handlerandregister_setfor thesetcommand - Implements
get_handlerandregister_getfor thegetcommand - Updates
register_commandsto include the new commands and adds<stdlib.h>for conversions
Comments suppressed due to low confidence (4)
components/esp_rainmaker/src/console/esp_rmaker_commands.c:268
- [nitpick] The help string is generic. Consider including the usage pattern (e.g.,
Usage: set <device_name> <param_name> <value>) to guide users.
.help = "Set command for ESP RainMaker device parameters",
components/esp_rainmaker/src/console/esp_rmaker_commands.c:333
- [nitpick] Include the usage syntax (e.g.,
Usage: get <device_name> <param_name>) in the help string for clarity.
.help = "Get command for ESP RainMaker device parameters",
components/esp_rainmaker/src/console/esp_rmaker_commands.c:198
- Consider adding unit or integration tests for the new
setcommand handler to validate parsing, type conversion, and error handling.
static int set_handler(int argc, char** argv)
components/esp_rainmaker/src/console/esp_rmaker_commands.c:264
- [nitpick]
register_setis ambiguous and inconsistent with otherregister_*_commandfunctions. Consider renaming toregister_set_commandfor clarity and consistency.
static void register_set()
- Update help strings with clear usage patterns - Improve function naming consistency - Add proper error handling and validation - Implement type-safe value conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new console commands to ESP RainMaker: