Thanks for your contribution 🙏🏽

imho, code clarity here is more convenient than saving the bool allocation.

I used to follow the same approach always thinking that could have perf impact, however i realized that using the bool as val, make the code more clear and easier to follow, specially when asserting the presence of a key, which is the case here.

That being said, i believe we need benchmarks in order to prove the perf gains.

Wdyt @ahrtr @ivanvc @fuweid

/ok-to-test

Hi @arturmelanchyk, Thanks for the pull request. Please ensure your commit is signed so the developer certificate of origin (DCO) check passes, i.e:

git rebase HEAD~1 --signoff
git push --force

Thanks again :)

Ref: https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#commit-your-change

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, arturmelanchyk, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

@arturmelanchyk would u kindly rebase against upstream/main

it has the fix for the windows timeout :)

@arturmelanchyk would u kindly rebase against upstream/main

it has the fix for the windows timeout :)

It's fine. Let's merge this PR.