increase default bcrypt work factor #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been 10 years since this default work factor was set, it's probably about time to quadruple the time it takes again. This random person benchmarked it on a modern-ish CPU and on cloud servers in 2023 and it seems like 12 is a good default now (taking around 200-400ms per hash)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been 10 years since this default work factor was set in the code, it's probably about time to quadruple the time it takes again.
This random person benchmarked it on a modern-ish CPU and on cloud servers in 2023 and it seems like 12 is a good default now (taking around 200-400ms per hash - the original implementation suggests at least 250ms)