Support ejs 2.0 #2452
Merged
Support ejs 2.0 #2452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I decided to use |
Fixes #2437. This is still relying on undocumented behavior, but should unbreak the app in the mean time.
|
Perfect, thanks! |
|
Does this include the issue with plugins not showing up? Our initial fix unbroke the build, but I'm not sure it was a total fix. |
|
Oh good point mde, I will test that now |
|
it should... |
|
Ah damn no it doesn't ;( Plugins still not showing up.. I should really have test coverage for that... |
|
I'm fine with reverting this commit for now. Just wanted to help. |
|
Yea let's revert for now, hopefully @mde can get a perma fix in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2437.