Packaging improvement #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this today. Problem is that minfied:false doesn't work anymore. Without this its nearly impossible to debug the client side code. Can you please try to fix that |
|
Another side effect of this pull request is that line numbers are not showed anymore |
Instead of replacing substrings, write each included file's content into a shared dictionary for lookup later. This eliminates duplication and arguably improves readability.
|
Oh, that’s right… fixed. |
|
Great work thanks :) |
|
Awesome work. Thx a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks the process of embedding styles and scripts into
ace.js. It’s slightly cleaner, but the important bit is that files are included at most once. This eliminates duplication and drops the size ofpad.jsfrom 149.27kB (553.98kB) to 109.47kB (341.96kB). This patch also changes how tags are written to the page so that only one style and one script tag are created (my intuition is that this will help IE).