Add checks to signature recovery #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23576c3 to
05e7756
Compare
petertdavies
approved these changes
Sep 19, 2024
gurukamath
added a commit
to gurukamath/execution-specs
that referenced
this pull request
Jan 31, 2025
gurukamath
added a commit
that referenced
this pull request
Feb 3, 2025
nerolation
pushed a commit
to nerolation/execution-specs
that referenced
this pull request
Feb 7, 2025
* port ethereum#1098 to prague * port ethereum#1011 to prague
nerolation
pushed a commit
to nerolation/execution-specs
that referenced
this pull request
Feb 9, 2025
* port ethereum#1098 to prague * port ethereum#1011 to prague
nerolation
pushed a commit
to nerolation/execution-specs
that referenced
this pull request
Feb 10, 2025
* port ethereum#1098 to prague * port ethereum#1011 to prague
fselmo
pushed a commit
to fselmo/execution-specs
that referenced
this pull request
Apr 9, 2025
* port ethereum#1098 to prague * port ethereum#1011 to prague
SamWilsn
pushed a commit
to SamWilsn/eth1.0-specs
that referenced
this pull request
Apr 11, 2025
* port ethereum#1098 to prague * port ethereum#1011 to prague
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The current sender recovery does not check if the
rvalue in the signature is a valid one.How was it fixed?
Add a additional check to the
secp256k1_recoverfunction.