Rewrite new fork tool to modify blob parameters #1372
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1372 +/- ##
============================================
Coverage 86.07% 86.08%
============================================
Files 743 743
Lines 44072 44072
Branches 3891 3891
============================================
+ Hits 37936 37938 +2
+ Misses 5659 5656 -3
- Partials 477 478 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7909e08 to
ebd7090
Compare
|
|
||
| blob_parameters = parser.add_argument_group() | ||
|
|
||
| blob_parameters.add_argument( |
There was a problem hiding this comment.
This could get a bit more complicated since post-Osaka, we won't have TARGET_BLOB_GAS_PER_BLOCK as ain independent constant. See this
There was a problem hiding this comment.
Should we disable this option post-osaka or allow users to modify it at their own risk?
615b3db to
2347cb8
Compare
|
What a finicky tool. Should be good to review now. |
`actions-rs` has been archived and is no longer the recommended way to install packages. Instead, I'm using the Ubuntu-provided `rustup`.
2347cb8 to
8138137
Compare
What was wrong?
Related to Issue #1357
How was it fixed?
Rewrote the new fork tool to be more than just find-and-replace. It now uses libcst to transform the source somewhat intelligently.
Cute Animal Picture