Wrong fix.

Coverage remained the same at 85.828% when pulling d3473fc on removePrepublishOnlyFromPretest into fb7a98d on master.

I think it's actually a good fix, you just needed to update the CI config to download the binary.

Another solution would be to replace prepublishOnly with prepare, which provides the old functionality:

Deprecation Note: prepublish

Since [email protected], the npm CLI has run the prepublish script for both npm publish and npm install, because it's a convenient way to prepare a package for use (some common use cases are described in the section below). It has also turned out to be, in practice, very confusing. As of [email protected], a new event has been introduced, prepare, that preserves this existing behavior. A new event, prepublishOnly has been added as a transitional strategy to allow users to avoid the confusing behavior of existing npm versions and only run on npm publish (for instance, running the tests one last time to ensure they're in good shape).

See npm/npm#10074 for a much lengthier justification, with further reading, for this change.

I checked and, unlike prepublishOnly, prepare can be disabled in npm config so it would just require tweaking the name in ethereum/solidity#11805.

But I'd rather keep prepublishOnly. Overwriting the binary on npm run test is not a very friendly behavior. I'd expect tests to run against what I have in the repo, and not replace it with something completely different. It should not be the default behavior, especially given that it's so hard to disable.

I pushed a change that runs the download in the CI. I also created a new command - npm run updateBinary to make it more explicit.

I'd approve, but I can't, since I authored.

Oh :)